karuppayya commented on code in PR #12893:
URL: https://github.com/apache/iceberg/pull/12893#discussion_r2072166431
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkExecutorCache.java:
##########
@@ -70,10 +70,10 @@ private SparkExecutorCache(Conf conf) {
*
* <p>Note this method returns null if caching is disabled.
*/
- public static SparkExecutorCache getOrCreate() {
+ public static SparkExecutorCache getOrCreate(boolean forDeletes) {
Review Comment:
The Javadoc needs to be updated
also add the additional parameter
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkExecutorCache.java:
##########
@@ -70,10 +70,10 @@ private SparkExecutorCache(Conf conf) {
*
* <p>Note this method returns null if caching is disabled.
*/
- public static SparkExecutorCache getOrCreate() {
Review Comment:
Given its a public API, should we introduce a new method which takes the
additional param?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
