hsingh574 commented on PR #12855: URL: https://github.com/apache/iceberg/pull/12855#issuecomment-2822566383
Thanks for taking a look. I made an incorrect update to that unit test which caused the failure. Updated in the latest commit and it passed locally. Regarding container reuse in general, I don't see how to generate a set of all equality delete records (for ByteBuffers for example) without copying at some point (for positional deletes afaict we don't reuse anything anyways). We could introduce a "ContainerPool" which has several different sized containers to choose from that can be reused, but seems like we still need a copy at some point to avoid overwriting data. Maybe there's a way to change the contract of DeleteLoader to avoid this problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
