RussellSpitzer commented on code in PR #12824: URL: https://github.com/apache/iceberg/pull/12824#discussion_r2054926473
########## api/src/main/java/org/apache/iceberg/actions/RewriteDataFiles.java: ########## @@ -86,6 +86,12 @@ public interface RewriteDataFiles int MAX_CONCURRENT_FILE_GROUP_REWRITES_DEFAULT = 5; + /** + * The max number of files to be rewritten. By default, this value will be 0 (To rewrite all the + * files) + */ + String MAX_FILES_TO_REWRITE = "max-files-to-rewrite"; Review Comment: I'm not a fan of magic 0's. Could we just not-limit the number of files if this value isn't set? (0 could also just be an unacceptable value for a user to pass in as well) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
