sririshindra commented on code in PR #12824:
URL: https://github.com/apache/iceberg/pull/12824#discussion_r2049439045
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java:
##########
@@ -407,15 +409,49 @@ private Builder doExecuteWithPartialProgress(
Stream<RewriteFileGroup> toGroupStream(
RewriteExecutionContext ctx, Map<StructLike, List<List<FileScanTask>>>
groupsByPartition) {
- return groupsByPartition.entrySet().stream()
+ if (maxFilesToRewrite == null) {
Review Comment:
Actually can we instead set this value to LONG.MAX_FILES_TO_REWRITE by
default, so that you don't have to have two code blocks to do the same thing.
If the user doesn't specify this option, then MAX_FILES_TO_REWRITE is set to
the default. So, along as the number of files being processed doesn't't exceed
LONG.MAX_FILES_TO_REWRITE your implementation for the case when
MAX_FILES_TO_REWRITE is set to some value will suffice.
If you instead decide to make the criteria something like
MAX_FILES_SIZE_TO_REWRITE then the same trick works there as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
