RussellSpitzer commented on code in PR #12840:
URL: https://github.com/apache/iceberg/pull/12840#discussion_r2054902795
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteManifestsSparkAction.java:
##########
@@ -161,6 +169,29 @@ public RewriteManifestsSparkAction stagingLocation(String
newStagingLocation) {
return this;
}
+ @Override
+ public RewriteManifestsSparkAction clusterBy(List<String> partitionFields) {
+ // Collect set of available partition columns to cluster on
+ Set<String> availablePartitionNames =
+
spec.fields().stream().map(PartitionField::name).collect(Collectors.toSet());
+
+ // Identify specified partition fields that are not available in the spec
+ List<String> missingFields =
+ partitionFields.stream()
+ .filter(field -> !availablePartitionNames.contains(field))
+ .collect(Collectors.toList());
+
+ // Check if these partition fields are included in the spec
+ Preconditions.checkArgument(
+ missingFields.isEmpty(),
+ "Cannot set manifest clustering because specified field(s) %s were not
found in current partition spec %s.",
+ missingFields,
+ this.spec.specId());
Review Comment:
🤷 You could always have both if someone really wanted that id ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
