RussellSpitzer commented on code in PR #12840:
URL: https://github.com/apache/iceberg/pull/12840#discussion_r2054899744
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteManifestsSparkAction.java:
##########
@@ -251,12 +282,40 @@ private List<ManifestFile> writeUnpartitionedManifests(
private List<ManifestFile> writePartitionedManifests(
ManifestContent content, Dataset<Row> manifestEntryDF, int numManifests)
{
+ // Extract desired clustering criteria into a dedicated column
+ Dataset<Row> clusteredManifestEntryDF;
+
+ if (partitionFieldClustering != null) {
+ LOG.info(
+ "Clustering manifests for specId {} by partition columns by {} ",
+ spec.specId(),
+ partitionFieldClustering);
+
+ // Map the top level partition column names to the column name
referenced within the manifest
+ // entry dataframe
+ Column[] actualPartitionColumns =
Review Comment:
Generally we would want to only include additional words if it distinguishes
this from other columns. I don't think we have any "non-actual" partition
columns here.
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteManifestsSparkAction.java:
##########
@@ -251,12 +282,40 @@ private List<ManifestFile> writeUnpartitionedManifests(
private List<ManifestFile> writePartitionedManifests(
ManifestContent content, Dataset<Row> manifestEntryDF, int numManifests)
{
+ // Extract desired clustering criteria into a dedicated column
+ Dataset<Row> clusteredManifestEntryDF;
+
+ if (partitionFieldClustering != null) {
+ LOG.info(
+ "Clustering manifests for specId {} by partition columns by {} ",
+ spec.specId(),
+ partitionFieldClustering);
+
+ // Map the top level partition column names to the column name
referenced within the manifest
+ // entry dataframe
+ Column[] actualPartitionColumns =
Review Comment:
Generally we would want to only include additional words if it distinguishes
this from variables columns. I don't think we have any "non-actual" partition
columns here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
