RussellSpitzer commented on code in PR #12212:
URL: https://github.com/apache/iceberg/pull/12212#discussion_r2054455511
##########
data/src/main/java/org/apache/iceberg/data/TableMigrationUtil.java:
##########
@@ -163,10 +167,19 @@ public static List<DataFile> listPartition(
Path partitionDir = new Path(partitionUri);
FileSystem fs = partitionDir.getFileSystem(conf);
- List<FileStatus> fileStatus =
- Arrays.stream(fs.listStatus(partitionDir, HIDDEN_PATH_FILTER))
- .filter(FileStatus::isFile)
- .collect(Collectors.toList());
+ List<FileStatus> fileStatus;
+ if (fs.exists(partitionDir)) {
Review Comment:
We added a flag "checkDuplicateFiles" to Spark Table util.
I'm afraid we don't have a clean way of adding more parameters to this
method method but i'm still not confident we should go from failure to warning
for everyone all at once.
I think it may be best to have a flag in the caller so it looks something
like
```
try {
listPartition(ex)
} Catch (FileNotFound ...) {
if (ignoreMissingFiles)
log.warn
else
throw FNF
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
