nastra commented on code in PR #12853:
URL: https://github.com/apache/iceberg/pull/12853#discussion_r2053443377
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java:
##########
@@ -972,33 +974,38 @@ private void assertSnapshotFileCount(SnapshotTable
snapshotTable, String source,
long expectedFiles = expectedFilesCount(source);
SnapshotTable.Result snapshotTableResult = snapshotTable.execute();
validateTables(source, dest);
- Assert.assertEquals(
- "Expected number of imported snapshot files",
- expectedFiles,
- snapshotTableResult.importedDataFilesCount());
+ assertThat(snapshotTableResult.importedDataFilesCount())
+ .as("Expected number of imported snapshot files")
+ .isEqualTo(expectedFiles);
}
private void validateTables(String source, String dest)
throws NoSuchTableException, ParseException {
List<Row> expected = spark.table(source).collectAsList();
SparkTable destTable = loadTable(dest);
- Assert.assertEquals(
- "Provider should be iceberg",
- "iceberg",
- destTable.properties().get(TableCatalog.PROP_PROVIDER));
+ assertThat(destTable.properties().get(TableCatalog.PROP_PROVIDER))
Review Comment:
it would be better to use `.containsEntry` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
