tomtongue commented on code in PR #12853: URL: https://github.com/apache/iceberg/pull/12853#discussion_r2051872723
########## spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/actions/TestCreateActions.java: ########## @@ -547,28 +557,24 @@ public void testSparkTableReservedProperties() throws Exception { String[] keys = {"provider", "format", "current-snapshot-id", "location", "sort-order"}; for (String entry : keys) { - Assert.assertTrue( - "Created table missing reserved property " + entry, - table.properties().containsKey(entry)); + assertThat(table.properties()) + .as("Created table missing reserved property " + entry) + .containsKey(entry); Review Comment: Thank you! Let me update the Spark 3.5 as well (and thanks for pointing the string style for `as`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org