liurenjie1024 commented on issue #1228: URL: https://github.com/apache/iceberg-rust/issues/1228#issuecomment-2816484998
> One thing I'm concerned about is that there may be a specific parameter to create the catalog, e.g. [S3Catalog](https://github.com/apache/iceberg-rust/blob/609b792e3f85c835bc9f0898f2ea5ee5eba215e9/crates/catalog/s3tables/src/catalog.rs#L40) and [GlueCatalog](https://github.com/apache/iceberg-rust/blob/609b792e3f85c835bc9f0898f2ea5ee5eba215e9/crates/catalog/glue/src/catalog.rs#L45) have different catalog configs. In this case, looks like it's hard to unify the with_xxx of them? This configuration could all be configured by keys. For example, `table_bucket_arn` in `S3Catalog` could be configured with a key like `s3.catalog.table.bucket.arn`. > For example, the REST Catalog supports setting an HttpClient. How can we enable CatalogBuilder to support this as well? Alternatively, should we treat CatalogBuilder as an entry point, and recommend that advanced users—such as those who need to configure the HttpClient—use RestCatalogBuilder directly? Yeah, I totally agree with it. The `load_catalog` api is to allow user to have a convenient way to creat catalog, but advanced user should still use concrete catalog builder directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
