ZENOTME commented on issue #1228:
URL: https://github.com/apache/iceberg-rust/issues/1228#issuecomment-2815494882
Thanks @liurenjie1024 for raising this discussion. According to my
understanding, the CatalogBuilder is used to let us have a unified way to
create catalog like following, right?
```
let catalog_builder = load_catalog(xxx);
catalog_builder.with_name()
.with_xxx()
...
let catalog = catalog_builder.build()
```
One thing I'm concerned about is that there may be a specific parameter to
create the catalog, e.g.
[S3Catalog](https://github.com/apache/iceberg-rust/blob/609b792e3f85c835bc9f0898f2ea5ee5eba215e9/crates/catalog/s3tables/src/catalog.rs#L40)
and
[GlueCatalog](https://github.com/apache/iceberg-rust/blob/609b792e3f85c835bc9f0898f2ea5ee5eba215e9/crates/catalog/glue/src/catalog.rs#L45)
have different catalog configs. In this case, looks like it's hard to unify
the `with_xxx` of them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
