sungwy commented on code in PR #1935:
URL: https://github.com/apache/iceberg-python/pull/1935#discussion_r2051346707
##########
pyiceberg/table/snapshots.py:
##########
@@ -429,3 +429,13 @@ def ancestors_of(current_snapshot: Optional[Snapshot],
table_metadata: TableMeta
if snapshot.parent_snapshot_id is None:
break
snapshot = table_metadata.snapshot_by_id(snapshot.parent_snapshot_id)
+
+
+def ancestors_between(
+ current_snapshot: Optional[Snapshot], oldest_snapshot: Snapshot,
table_metadata: TableMetadata
Review Comment:
This doesn't looks correct: the `current_snapshot` is a required field
`oldest_snapshot` could be None and in that case, we also should provide the
entire list of ancestors of the `current_snapshot`
I think the implementation that's in progress on this PR is closer to what
we'd want: https://github.com/apache/iceberg-python/pull/533/files
##########
pyiceberg/table/update/validate.py:
##########
@@ -0,0 +1,70 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from pyiceberg.manifest import ManifestContent, ManifestFile
+from pyiceberg.table import Table
+from pyiceberg.table.snapshots import Operation, Snapshot, ancestors_between
+
+
+class ValidationException(Exception):
+ """Raised when validation fails."""
+
+
+def validation_history(
+ table: Table,
+ starting_snapshot: Snapshot,
Review Comment:
`starting_snapshot` should be Optional, because it could be missing. If the
`starting_snapshot` for validation is missing, and if the isolation level is
specified (not None) then we'd need to run the validation check from the
beginning of the table's history - this is the current behavior in the Java
reference implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
