jayceslesar commented on code in PR #1935:
URL: https://github.com/apache/iceberg-python/pull/1935#discussion_r2051103956
##########
pyiceberg/table/snapshots.py:
##########
@@ -255,6 +255,14 @@ def manifests(self, io: FileIO) -> List[ManifestFile]:
"""Return the manifests for the given snapshot."""
return list(_manifests(io, self.manifest_list))
+ def data_manifests(self, io: FileIO) -> List[ManifestFile]:
+ """Return the data manifests for the given snapshot."""
+ return [manifest for manifest in self.manifests(io) if
manifest.content == ManifestContent.DATA]
+
+ def delete_manifests(self, io: FileIO) -> List[ManifestFile]:
+ """Return the delete manifests for the given snapshot."""
+ return [manifest for manifest in self.manifests(io) if
manifest.content == ManifestContent.DELETES]
+
Review Comment:
Might be cleaner to just allow passing an optional `content_filter` to the
`manifest` method instead of exposing two new methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
