ebyhr commented on code in PR #12822:
URL: https://github.com/apache/iceberg/pull/12822#discussion_r2049752147
##########
.baseline/checkstyle/checkstyle.xml:
##########
@@ -439,6 +439,11 @@
<property name="illegalClasses"
value="org.junit.rules.ExpectedException"/>
<message key="import.illegal" value="Prefer using
Assertions.assertThatThrownBy(...).isInstanceOf(...) instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanAssumeTrueUsage"/>
+ <property name="illegalPkgs"
value="org.junit.jupiter.api.Assumptions"/>
+ <message key="import.illegal" value="Prefer using
Assertions.assumeThat(...).as(...) instead."/>
Review Comment:
```suggestion
<message key="import.illegal" value="Prefer using
Assertions.assumeThat(...).isTrue() instead."/>
```
##########
core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java:
##########
@@ -2754,9 +2743,7 @@ public void testConcurrentReplaceTransactionSchema2() {
@Test
public void testConcurrentReplaceTransactionSchemaConflict() {
- assumeThat(supportsServerSideRetry())
- .isEqualTo(true)
- .as("Schema conflicts are detected server-side");
+ assumeThat(supportsServerSideRetry()).isTrue().as("Schema conflicts are
detected server-side");
Review Comment:
```suggestion
assumeThat(supportsServerSideRetry()).as("Schema conflicts are detected
server-side").isTrue();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
