nastra commented on code in PR #12822:
URL: https://github.com/apache/iceberg/pull/12822#discussion_r2048295281
##########
core/src/test/java/org/apache/iceberg/util/TestEnvironmentUtil.java:
##########
@@ -19,19 +19,20 @@
package org.apache.iceberg.util;
import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assumptions.assumeThat;
import java.util.Map;
import java.util.Optional;
import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
-import org.junit.jupiter.api.Assumptions;
import org.junit.jupiter.api.Test;
class TestEnvironmentUtil {
@Test
public void testEnvironmentSubstitution() {
Optional<Map.Entry<String, String>> envEntry =
System.getenv().entrySet().stream().findFirst();
- Assumptions.assumeTrue(
- envEntry.isPresent(), "Expecting at least one env. variable to be
present");
+ assumeThat(envEntry.isPresent())
+ .isEqualTo(true)
+ .as("Expecting at least one env. variable to be present");
Review Comment:
the .as() part needs to come before the final assertion, otherwise it will
be ignored. We should also use .isTrue() here (as mentioned in a previous
comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
