rdblue commented on code in PR #12658: URL: https://github.com/apache/iceberg/pull/12658#discussion_r2049500773
########## format/spec.md: ########## @@ -648,6 +648,9 @@ Notes: 5. The `content_offset` and `content_size_in_bytes` fields are used to reference a specific blob for direct access to a deletion vector. For deletion vectors, these values are required and must exactly match the `offset` and `length` stored in the Puffin footer for the deletion vector blob. 6. The following field ids are reserved on `data_file`: 141. +For `variant` type, the `lower_bounds` and `upper_bounds` store the lower and upper bounds for the shredded fields within a file with the following considerations: 1) Bounds for array data are not collected; 2) The lower / upper bounds are collected only if all field data share the same shredded type or if the data is missing. These bounds are represented as a Variant object, where each field path serves as a key and the corresponding bound value as the value. The object is then serialized into binary format (see [Variant encoding](https://github.com/apache/parquet-format/blob/master/VariantEncoding.md)). +Field paths follow the JSON path format to use normalized path, such as `$['location']['latitude']` or `$['user.name']`. The special path `$` represents bounds for the variant root, indicating that the variant data consists of uniform primitive types, such as strings. Review Comment: ```suggestion Field paths follow the JSON path format to use normalized path, such as `$['location']['latitude']` or `$['user.name']`. The special path `$` represents bounds for the variant root, indicating that the variant data consists of uniform primitive types, such as strings. Examples of valid field paths using normalized JSON path format are: * `$` -- the Variant root value * `$['user.name']` -- the field `"user.name"` in the root value that is a Variant object * `$['location']['latitude']` -- the field `latitude` in a nested `location` object * `$['ids']` -- the `ids` array * `$['addresses']['zip']` -- the field `zip` in an `addresses` array that contains objects ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
