huaxingao commented on code in PR #12494: URL: https://github.com/apache/iceberg/pull/12494#discussion_r2048337957
########## spark/v4.0/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/RewriteViewCommands.scala: ########## @@ -65,7 +65,7 @@ case class RewriteViewCommands(spark: SparkSession) extends Rule[LogicalPlan] wi allowExisting = allowExisting, replace = replace) - case view @ ShowViews(_, pattern, output) => + case view @ ShowViews(CurrentNamespace, pattern, output) => Review Comment: Even though `CurrentNamespace` is not used, we can't use `case view @ ShowViews(_, pattern, output)`, because need to differentiate from the next case `case ShowViews(UnresolvedNamespace(CatalogAndNamespace(catalog, ns), _), pattern, output)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org