RussellSpitzer commented on code in PR #12494:
URL: https://github.com/apache/iceberg/pull/12494#discussion_r2047176440
##########
spark/v4.0/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestCallStatementParser.java:
##########
@@ -69,16 +70,9 @@ public static void stopSpark() {
}
@Test
- public void testDelegateUnsupportedProcedure() {
- assertThatThrownBy(() -> parser.parsePlan("CALL cat.d.t()"))
- .isInstanceOf(ParseException.class)
- .hasMessageContaining("Syntax error")
- .satisfies(
- exception -> {
- ParseException parseException = (ParseException) exception;
-
assertThat(parseException.getErrorClass()).isEqualTo("PARSE_SYNTAX_ERROR");
-
assertThat(parseException.getMessageParameters().get("error")).isEqualTo("'CALL'");
- });
+ public void testDelegateUnsupportedProcedure() throws ParseException {
+ LogicalPlan plan = parser.parsePlan("CALL cat.d.t()");
+ assertThat(plan.toString().contains("CALL cat.d.t()"));
Review Comment:
Shouldn't we just remove this test then? I'm not sure what we are checking
here any more?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
