RussellSpitzer commented on code in PR #12494: URL: https://github.com/apache/iceberg/pull/12494#discussion_r2047003296
########## gradle/libs.versions.toml: ########## @@ -92,6 +94,8 @@ aliyun-sdk-oss = { module = "com.aliyun.oss:aliyun-sdk-oss", version.ref = "aliy analyticsaccelerator-s3 = { module = "software.amazon.s3.analyticsaccelerator:analyticsaccelerator-s3", version.ref = "analyticsaccelerator" } antlr-antlr4 = { module = "org.antlr:antlr4", version.ref = "antlr" } antlr-runtime = { module = "org.antlr:antlr4-runtime", version.ref = "antlr" } +antlr-antlr413 = { module = "org.antlr:antlr4", version.ref = "antlr413" } +antlr-runtime413 = { module = "org.antlr:antlr4-runtime", version.ref = "antlr413" } Review Comment: This feels a little odd to me, Do we really need a second antlr version? Is there incompatibility with the runtime? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org