nastra commented on code in PR #12808:
URL: https://github.com/apache/iceberg/pull/12808#discussion_r2046286635
##########
.github/labeler.yml:
##########
@@ -148,7 +148,9 @@ GCP:
- changed-files:
- any-glob-to-any-file: [
'gcp/**/*',
- 'gcp-bundle/**/*'
+ 'gcp-bundle/**/*',
+ 'bigquery/**/*',
+ 'bigquery-bundle/**/*'
Review Comment:
there isn't a bigquery-bundle, so I believe this can be removed
##########
build.gradle:
##########
@@ -657,6 +657,49 @@ project(':iceberg-delta-lake') {
}
}
+project(':iceberg-bigquery') {
+ test {
+ useJUnitPlatform()
+ }
+
+ dependencies {
+ implementation project(path: ':iceberg-bundled-guava', configuration:
'shadow')
+ implementation project(':iceberg-gcp')
+
+ implementation platform(libs.google.libraries.bom)
+ compileOnly "com.google.cloud:google-cloud-storage"
+ implementation "com.google.cloud:google-cloud-bigquery"
+ implementation "com.google.cloud:google-cloud-core"
+
+ api project(':iceberg-api')
+ implementation project(':iceberg-common')
+ implementation project(':iceberg-core')
+
+ compileOnly("org.apache.hadoop:hadoop-common:3.4.1")
Review Comment:
this should be referencing the version defined in `libs.versions.toml` via
`libs.versions.hadoop3.common`
##########
build.gradle:
##########
@@ -657,6 +657,49 @@ project(':iceberg-delta-lake') {
}
}
+project(':iceberg-bigquery') {
+ test {
+ useJUnitPlatform()
+ }
+
+ dependencies {
+ implementation project(path: ':iceberg-bundled-guava', configuration:
'shadow')
+ implementation project(':iceberg-gcp')
+
+ implementation platform(libs.google.libraries.bom)
+ compileOnly "com.google.cloud:google-cloud-storage"
+ implementation "com.google.cloud:google-cloud-bigquery"
+ implementation "com.google.cloud:google-cloud-core"
+
+ api project(':iceberg-api')
+ implementation project(':iceberg-common')
+ implementation project(':iceberg-core')
+
+ compileOnly("org.apache.hadoop:hadoop-common:3.4.1")
+ compileOnly("org.apache.hive:hive-metastore:4.0.1") {
+ exclude group: 'org.apache.avro', module: 'avro'
+ exclude group: 'org.slf4j', module: 'slf4j-log4j12'
+ exclude group: 'org.pentaho' // missing dependency
+ exclude group: 'org.apache.hbase'
+ exclude group: 'org.apache.logging.log4j'
+ exclude group: 'co.cask.tephra'
+ exclude group: 'com.google.code.findbugs', module: 'jsr305'
+ exclude group: 'org.eclipse.jetty.aggregate', module: 'jetty-all'
+ exclude group: 'org.eclipse.jetty.orbit', module: 'javax.servlet'
+ exclude group: 'org.apache.parquet', module: 'parquet-hadoop-bundle'
+ exclude group: 'com.tdunning', module: 'json'
+ exclude group: 'javax.transaction', module: 'transaction-api'
+ exclude group: 'com.zaxxer', module: 'HikariCP'
+ exclude group: 'com.google.code.gson', module: 'gson'
+ }
+
+ testImplementation project(path: ':iceberg-core', configuration:
'testArtifacts')
+ testImplementation project(path: ':iceberg-api', configuration:
'testArtifacts')
+
+ testImplementation 'org.mockito:mockito-core:5.12.0'
Review Comment:
this dependency should already be included via
https://github.com/apache/iceberg/blob/main/build.gradle#L205, so can be
removed here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
