tomtongue opened a new pull request, #12807: URL: https://github.com/apache/iceberg/pull/12807
*Migrate Spark 3.4 tests based on JUnit 4 to Junit5 with AssertJ style. This is related to https://github.com/apache/iceberg/issues/7160* This PR migrates the below tests, which are related to extensions test base in Spark 3.4, into JUnit 5 with AssertJ. The following classes are included in this PR: * Snapshot Manipulation: * `TestAncestorsOfProcedure` * `TestCherrypickSnapshotProcedure` (Replace `import static org.assertj.core.api.AssertionsForClassTypes.assertThat;` with `Assertions.assertThat` because the previous one is only for Java 8 which has been deprecated in recent Iceberg verions) * `TestSetCurrentSnapshotProcedure` (Replace `AssertionsForClassTypes.assertThat` with `Assertions.assertThat` as well) * `TestRollbackToSnapshotProcedure` (Replace `AssertionsForClassTypes.assertThat` with `Assertions.assertThat`) * `TestRollbackToTimestampProcedure` (Replace `AssertionsForClassTypes.assertThat` with `Assertions.assertThat`) * Change log view * `TestChangelogTable` including the backport from 3.5 tests * `TestCreateChangelogViewProcedure` * Distribution and ordering: * `TestRequiredDistributionAndOrdering` * `TestSetWriteDistributionAndOrdering` including the backport from https://github.com/apache/iceberg/pull/10774 * Additional tests: * `TestCallStatementParser` * `TestConflictValidation` * `TestMetaColumnProjectionWithStageScan` * `TestStoragePartitionedJoinsInRowLevelOperations` * `TestSystemFunctionPushDownDQL` * `TestSystemFunctionPushDownInRowLevelOperations` * `TestWriteAborts` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
