danielcweeks commented on code in PR #12781: URL: https://github.com/apache/iceberg/pull/12781#discussion_r2045730155
########## format/spec.md: ########## @@ -418,7 +416,7 @@ Engines may model operations as deleting/inserting rows or as modifications to r This example demonstrates how `_row_id` and `_last_updated_sequence_number` are assigned for a snapshot. This starts with a table with a `next-row-id` of 1000. -Writing a new append snapshot would create snapshot metadata with `first-row-id` assigned to the table's `next-row-id`: +Writing a new append snapshot creates snapshot metadata with `first-row-id` assigned to the table's `next-row-id`: Review Comment: Is this limited to `append`? I would think any snapshot (including rewrite) should assign ids. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
