rdblue commented on code in PR #12781: URL: https://github.com/apache/iceberg/pull/12781#discussion_r2043112788
########## format/spec.md: ########## @@ -736,8 +738,6 @@ A snapshot's `first-row-id` is assigned to the table's current `next-row-id` on The snapshot's `first-row-id` is the starting `first_row_id` assigned to manifests in the snapshot's manifest list. -The snapshot's `added-rows` is the sum of all the [`added_rows_count`](#manifest-lists) in all added manifests. Review Comment: @RussellSpitzer, I've removed `added-rows` because I think that it is misleading and makes row ID range assignment more complicated. In this PR, row ID range assignment is based on the total number of existing or added rows in new manifests. That leaves room for any data files that are missing `first_row_id` even if the files are `existing` and not `added`. That may not be the total number of added rows so I don't think it makes sense to have `added-rows` in the snapshot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
