jhump commented on code in PR #385:
URL: https://github.com/apache/iceberg-go/pull/385#discussion_r2045597490
##########
manifest.go:
##########
@@ -450,16 +450,13 @@ func fetchManifestEntries(m ManifestFile, fs iceio.IO,
discardDeleted bool) ([]M
}
defer f.Close()
- dec, err := ocf.NewDecoder(f)
+ dec, err := ocf.NewDecoder(f,
ocf.WithDecoderSchemaCache(&avro.SchemaCache{}))
if err != nil {
return nil, err
}
metadata := dec.Metadata()
- sc, err := avro.ParseBytes(dec.Metadata()["avro.schema"])
- if err != nil {
- return nil, err
- }
Review Comment:
I just happened to notice this and updated it so it doesn't re-parse the
schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
