ebyhr commented on code in PR #12784:
URL: https://github.com/apache/iceberg/pull/12784#discussion_r2043415467
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAddFilesProcedure.java:
##########
@@ -1109,6 +1109,22 @@ public void testAddFilesPartitionedWithParallelism() {
sql("SELECT id, name, dept, subdept FROM %s ORDER BY id", tableName));
}
+ @TestTemplate
+ public void testAddFilesWithInvalidParallelism() {
+ createUnpartitionedHiveTable();
+
+ createIcebergTable(
+ "id Integer, name String, dept String, subdept String", "PARTITIONED
BY (id)");
+
+ assertThatThrownBy(
+ () ->
+ sql(
+ "CALL %s.system.add_files(table => '%s', source_table =>
'%s', parallelism => -1)",
Review Comment:
nit: Testing with the boundary value `0` is more natural. I know
`testMigrateWithInvalidParallelism` uses `-1`, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
