manuzhang commented on code in PR #12709:
URL: https://github.com/apache/iceberg/pull/12709#discussion_r2039732716
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkPartitioningAwareScan.java:
##########
@@ -171,10 +174,17 @@ protected Set<PartitionSpec> specs() {
protected synchronized List<T> tasks() {
if (tasks == null) {
+ boolean hasDeletes = false;
try (CloseableIterable<? extends ScanTask> taskIterable =
scan.planFiles()) {
List<T> plannedTasks = Lists.newArrayList();
for (ScanTask task : taskIterable) {
+ if (task instanceof FileScanTask) {
+ if (!((FileScanTask) task).deletes().isEmpty()) {
Review Comment:
We already have `TableScanUtil.hasDeletes`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
