manuzhang commented on code in PR #12709:
URL: https://github.com/apache/iceberg/pull/12709#discussion_r2039710466
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometDeleteColumnReader.java:
##########
@@ -53,7 +53,7 @@ private static class DeleteColumnReader extends
MetadataColumnReader {
DataTypes.BooleanType,
TypeUtil.convertToParquet(
new StructField("_deleted", DataTypes.BooleanType, false,
Metadata.empty())),
- false /* useDecimal128 = false */,
+ true /* useDecimal128 = true */,
Review Comment:
is there a UT to catch this change?
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometDeleteColumnReader.java:
##########
@@ -53,7 +53,7 @@ private static class DeleteColumnReader extends
MetadataColumnReader {
DataTypes.BooleanType,
TypeUtil.convertToParquet(
new StructField("_deleted", DataTypes.BooleanType, false,
Metadata.empty())),
- false /* useDecimal128 = false */,
+ true /* useDecimal128 = true */,
Review Comment:
Is there a UT to catch this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
