lliangyu-lin commented on code in PR #12718:
URL: https://github.com/apache/iceberg/pull/12718#discussion_r2031567794
##########
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java:
##########
@@ -343,28 +342,32 @@ public void testRenameTableFailsToCreateNewTable() {
public void testRenameTableFailsToDeleteOldTable() {
String namespace = createNamespace();
String tableName = createTable(namespace);
- // delete the old table metadata, so that drop old table will fail
+
+ // Simulate table was dropped during rename, where new table already
created and need to delete
+ // old table
+ GlueCatalog glueCatalogSpy = Mockito.spy(glueCatalog);
Review Comment:
I agree creating exception in this case is not very ideal. Let me try out
using spy to drop the table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
