lliangyu-lin commented on code in PR #12718:
URL: https://github.com/apache/iceberg/pull/12718#discussion_r2027881602
##########
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java:
##########
@@ -333,28 +332,33 @@ public void testRenameTableFailsToCreateNewTable() {
public void testRenameTableFailsToDeleteOldTable() {
Review Comment:
This test is failing because [GlueCatalog
dropTable](https://github.com/apache/iceberg/blob/main/aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java#L338-L347)
behavior has changed. It will check whether purge is enabled before refreshing
for the current metadata.
Hence, removing the parameter / metadata location from Glue won't cause
failures during rename because dropTable will not try to retrieve the metadata
and the rename will pass
```
GLUE.updateTable(
UpdateTableRequest.builder()
.databaseName(namespace)
.tableInput(TableInput.builder().name(tableName).parameters(Maps.newHashMap()).build())
.build());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
