fqaiser94 commented on code in PR #1165:
URL: https://github.com/apache/iceberg-rust/pull/1165#discussion_r2032210965
##########
crates/iceberg/src/puffin/metadata.rs:
##########
@@ -26,33 +26,33 @@ use crate::{Error, ErrorKind, Result};
/// Human-readable identification of the application writing the file, along
with its version.
/// Example: "Trino version 381"
-pub(crate) const CREATED_BY_PROPERTY: &str = "created-by";
+pub const CREATED_BY_PROPERTY: &str = "created-by";
/// Metadata about a blob.
/// For more information, see:
https://iceberg.apache.org/puffin-spec/#blobmetadata
#[derive(Debug, PartialEq, Eq, Serialize, Deserialize, Clone)]
#[serde(rename_all = "kebab-case")]
-pub(crate) struct BlobMetadata {
+pub struct BlobMetadata {
/// See blob types: https://iceberg.apache.org/puffin-spec/#blob-types
- pub(crate) r#type: String,
+ pub r#type: String,
Review Comment:
Sure, please take another look!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
