fqaiser94 commented on code in PR #1165:
URL: https://github.com/apache/iceberg-rust/pull/1165#discussion_r2026865964
##########
crates/iceberg/src/puffin/mod.rs:
##########
@@ -18,15 +18,23 @@
//! Iceberg Puffin implementation.
#![deny(missing_docs)]
-// Temporarily allowing this while crate is under active development
-#![allow(dead_code)]
mod blob;
+pub use blob::{Blob, APACHE_DATASKETCHES_THETA_V1};
+
mod compression;
+pub use compression::CompressionCodec;
+
mod metadata;
+pub use metadata::{BlobMetadata, FileMetadata, CREATED_BY_PROPERTY};
+
#[cfg(feature = "tokio")]
mod reader;
+#[cfg(feature = "tokio")]
+pub use reader::PuffinReader;
Review Comment:
Is this the best way to do this? Wondering b/c this generates `X is never
used` warnings when running `cargo build -p iceberg --no-default-features`
which makes sense but doesn't feel great.
Also note that the only reason I have to do this is b/c of the use of
`tokio::sync::OnceCell` in `PuffinReader` implementation. If there's a way to
avoid that, we potentially remove this cfg entirely. Note the previous
conversation on this topic though:
https://github.com/apache/iceberg-rust/pull/892#discussion_r1925017095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
