mimikwang commented on code in PR #382:
URL: https://github.com/apache/iceberg-go/pull/382#discussion_r2030455337
##########
table/metadata.go:
##########
@@ -38,7 +38,7 @@ const (
partitionFieldStartID = 1000
supportedTableFormatVersion = 2
- addPartionSpecAction = "add-partition-spec"
+ addPartionSpecAction = "add-spec"
Review Comment:
this need to match the partition action defined
[here](https://github.com/apache/iceberg-go/blob/7dedd611e1468ea2212c416066270c680a1c813c/table/updates.go#L28)
maybe we should use the same constants instead of duplicating
##########
table/metadata.go:
##########
@@ -38,7 +38,7 @@ const (
partitionFieldStartID = 1000
supportedTableFormatVersion = 2
- addPartionSpecAction = "add-partition-spec"
+ addPartionSpecAction = "add-spec"
Review Comment:
this needs to match the partition action defined
[here](https://github.com/apache/iceberg-go/blob/7dedd611e1468ea2212c416066270c680a1c813c/table/updates.go#L28)
maybe we should use the same constants instead of duplicating
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
