rdblue commented on code in PR #12346:
URL: https://github.com/apache/iceberg/pull/12346#discussion_r2008315387
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -543,6 +565,148 @@ public int hashCode() {
}
}
+ public static class GeometryType extends PrimitiveType {
+
+ private final String crs;
+
+ private GeometryType(String crs) {
Review Comment:
I think this can be simpler:
```java
private GeometryType(String crs) {
Preconditions.checkArgument(crs == null || !crs.isEmpty(), "Invalid
CRS: (empty string)");
this.crs = CRS84.equalsIgnoreCase(crs) ? null : crs;
```
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -543,6 +565,148 @@ public int hashCode() {
}
}
+ public static class GeometryType extends PrimitiveType {
+
+ private final String crs;
+
+ private GeometryType(String crs) {
Review Comment:
I think this can be simpler:
```java
private GeometryType(String crs) {
Preconditions.checkArgument(crs == null || !crs.isEmpty(), "Invalid
CRS: (empty string)");
this.crs = CRS84.equalsIgnoreCase(crs) ? null : crs;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
