Kontinuation commented on code in PR #12346:
URL: https://github.com/apache/iceberg/pull/12346#discussion_r2008614269
##########
core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java:
##########
@@ -536,6 +538,45 @@ public void testBasicCreateTable() {
assertThat(table.properties()).as("Should have table
properties").isNotNull();
}
+ @Test
+ public void testCreateGeospatialTable() {
Review Comment:
Moved it to `TestGeospatialTable` and switched from `HadoopCatalog` to
`InMemoryCatalog`.
##########
core/src/test/java/org/apache/iceberg/data/DataTest.java:
##########
@@ -129,24 +135,37 @@ protected boolean supportsVariant() {
return false;
}
+ protected boolean supportsGeospatial() {
+ return false;
+ }
+
@ParameterizedTest
@FieldSource("SIMPLE_TYPES")
public void testTypeSchema(Type type) throws IOException {
- Assumptions.assumeThat(
- supportsUnknown()
- || TypeUtil.find(type, t -> t.typeId() == Type.TypeID.UNKNOWN)
== null)
- .as("unknown is not yet implemented")
- .isTrue();
- Assumptions.assumeThat(
- supportsTimestampNanos()
- || TypeUtil.find(type, t -> t.typeId() ==
Type.TypeID.TIMESTAMP_NANO) == null)
- .as("timestamp_ns is not yet implemented")
- .isTrue();
- Assumptions.assumeThat(
- supportsVariant()
- || TypeUtil.find(type, t -> t.typeId() == Type.TypeID.VARIANT)
== null)
- .as("variant is not yet implemented")
- .isTrue();
+ if (!supportsUnknown()) {
Review Comment:
Reverted
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveSchemaUtil.java:
##########
@@ -166,6 +166,8 @@ private static String convertToTypeString(Type type) {
return "timestamp";
case FIXED:
case BINARY:
+ case GEOMETRY:
+ case GEOGRAPHY:
Review Comment:
I've reverted this change. Does it mean that Hive catalog won't support
geospatial columns?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
