divinerapier commented on code in PR #1153: URL: https://github.com/apache/iceberg-rust/pull/1153#discussion_r2025831546
########## crates/iceberg/src/io/storage_oss.rs: ########## @@ -0,0 +1,74 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use std::collections::HashMap; + +use opendal::raw::HttpClient; +use opendal::services::OssConfig; +use opendal::{Configurator, Operator}; +use url::Url; + +use crate::{Error, ErrorKind, Result}; + +/// Following are arguments for [oss file io](https://py.iceberg.apache.org/configuration/#alibaba-cloud-object-storage-service-oss). +/// oss endpoint. +pub const OSS_ENDPOINT: &str = "s3.endpoint"; Review Comment: From the perspective of configuration keys' content, they are indeed identical to S3's. But this is to maintain compatibility with Python's configuration items. Although OSS claims S3 protocol compatibility, during previous development (using aws-sdk-go to operate Aliyun OSS), we actually encountered compatibility issues. Therefore, we propose adding a native implementation specifically for Aliyun OSS. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
