divinerapier commented on code in PR #1153:
URL: https://github.com/apache/iceberg-rust/pull/1153#discussion_r2025822429


##########
crates/iceberg/src/io/storage.rs:
##########
@@ -45,6 +47,17 @@ pub(crate) enum Storage {
         client: reqwest::Client,
         config: Arc<S3Config>,
     },
+    #[cfg(feature = "storage-oss")]
+    Oss {
+        /// oss storage could have `oss://`.
+        /// Storing the scheme string here to return the correct path.
+        scheme_str: String,

Review Comment:
   <img width="1137" alt="image" 
src="https://github.com/user-attachments/assets/ba2cc042-c959-4feb-bf3a-670f240bfa49";
 />
   
   Because data written to Iceberg via Flink/Spark + OSS shows paths starting 
with oss:// in the REST catalog, which cannot be parsed or read using the S3 
protocol.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to