kevinjqliu commented on code in PR #313:
URL: https://github.com/apache/iceberg-go/pull/313#discussion_r2023572413
##########
dev/docker-compose.yml:
##########
@@ -65,6 +65,13 @@ services:
- 9001:9001
- 9000:9000
command: ["server", "/data", "--console-address", ":9001"]
+ azurite:
+ image: mcr.microsoft.com/azure-storage/azurite
+ container_name: azurite
+ hostname: azurite
+ ports:
+ - 10010:10000
Review Comment:
hm good catch. i dont think port `10000` and `10001` are used by the spark
container
https://github.com/apache/iceberg-go/blob/19a651409cceafc6e04375f80466b3aa124bc78b/dev/docker-compose.yml#L37-L38
this setup is [copied over from
pyiceberg](https://github.com/apache/iceberg-python/blob/4d4714a46241d0d89519a2a605dbce27b713a60e/dev/docker-compose-integration.yml#L35-L37)
which doesnt use those ports
i think we can remove those 2 ports from the spark container and use it in
the azure container. i would prefer this
alternatively we can use `11000` but map it to the same port
(`11000:11000`). Its good practice to reuse the same port when redirecting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
