kevinjqliu commented on code in PR #313:
URL: https://github.com/apache/iceberg-go/pull/313#discussion_r2023389280
##########
dev/docker-compose.yml:
##########
@@ -65,6 +65,13 @@ services:
- 9001:9001
- 9000:9000
command: ["server", "/data", "--console-address", ":9001"]
+ azurite:
+ image: mcr.microsoft.com/azure-storage/azurite
+ container_name: azurite
+ hostname: azurite
+ ports:
+ - 10010:10000
Review Comment:
nit: use the same port for consistency
```suggestion
- 10000:10000
```
##########
io/azure_integration_test.go:
##########
@@ -0,0 +1,159 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//go:build integration
+
+package io_test
+
+import (
+ "context"
+ "fmt"
+ "testing"
+
+ "github.com/Azure/azure-sdk-for-go/sdk/storage/azblob"
+ "github.com/Azure/azure-sdk-for-go/sdk/storage/azblob/bloberror"
+ "github.com/apache/iceberg-go"
+ "github.com/apache/iceberg-go/catalog"
+ sqlcat "github.com/apache/iceberg-go/catalog/sql"
+ "github.com/apache/iceberg-go/io"
+ "github.com/stretchr/testify/suite"
+ "github.com/uptrace/bun/driver/sqliteshim"
+ "gocloud.dev/blob/azureblob"
+)
+
+const (
+ accountName = "devstoreaccount1"
+ accountKey =
"Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw=="
+ endpoint = "127.0.0.1:10010"
+ protocol = "http"
+ containerName = "warehouse"
+ connectionString =
"DefaultEndpointsProtocol=http;AccountName=devstoreaccount1;AccountKey=Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==;BlobEndpoint=http://127.0.0.1:10010/devstoreaccount1;QueueEndpoint=http://127.0.0.1:10001/devstoreaccount1;TableEndpoint=http://127.0.0.1:10002/devstoreaccount1;";
Review Comment:
nit: this seems to be using the constants above, can we use string
interpolation here so that future changes can be made easier?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
