liurenjie1024 commented on code in PR #1149:
URL: https://github.com/apache/iceberg-rust/pull/1149#discussion_r2022859479
##########
crates/iceberg/src/spec/datatypes.rs:
##########
@@ -633,11 +633,11 @@ impl NestedField {
}
/// Construct list type's element field.
- pub fn list_element(id: i32, field_type: Type, required: bool) -> Self {
+ pub fn list_element(id: i32, field_type: Type, field_name: String,
required: bool) -> Self {
Review Comment:
I prefer to have two methods:
1. `list_element` method unchanged.
2. `list_element` with name, which accepts an extra name.
For the behavior, I didn't find equivalent things in java/python, but I
think it's reasonable as iceberg spec didn't enforce that list type element's
field name must be `element`. cc @Fokko @sdd WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
