jonathanc-n commented on code in PR #1149:
URL: https://github.com/apache/iceberg-rust/pull/1149#discussion_r2021852830
##########
crates/iceberg/src/spec/datatypes.rs:
##########
@@ -633,11 +633,11 @@ impl NestedField {
}
/// Construct list type's element field.
- pub fn list_element(id: i32, field_type: Type, required: bool) -> Self {
+ pub fn list_element(id: i32, field_type: Type, field_name: String,
required: bool) -> Self {
Review Comment:
Should this be an `Option<String>` or is this fine. The alternative is that
if `None` we can pass in `LIST_FIELD_NAME`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
