nastra commented on PR #12270: URL: https://github.com/apache/iceberg/pull/12270#issuecomment-2739357056
> +1 @nastra my only concern is to double check that we don't physically delete the file after removing it. That would be safe for PosDel files but not DVs. I couldn't find a place where that was happening, but we should make sure that there's nothing in the snapshot expiration or other paths that physically remove the files after we mark the entries deleted. thanks for the review @danielcweeks. I'll double check this and will follow up in a separate PR on this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
