kumarpritam863 commented on PR #12609: URL: https://github.com/apache/iceberg/pull/12609#issuecomment-2760377796
Yes for this I am already making the documentation more clear and may be a check also if possible. The problem is we cannot return false or throw exception before checking if the group is stable as this might lead to no-coordinator issue. According to me we should best address this in the documentation which I am already making changes for. My main concern here is if the only issue is people are not aware that connect-group-id should match the consumer-group-id then these logs will even not help in figuring out these easily and the only place where users can get clarity is through the documentation. If we are keen on adding logs then I think we should add just one debug logs towards the end without returning anything or throwing any exception because all those scenarios are very well handled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
