vl-kp commented on PR #12609:
URL: https://github.com/apache/iceberg/pull/12609#issuecomment-2759955749
> I do not think for that we should be having redundant checks on members as
that is the only scenario in which there will be no co-ordinator, in all cases
the open is called after assignment of partitions only. Also we can just look
for this logs: "Task elected leader, starting commit coordinator" -> which is
already there. Let me know your thoughts.
unfortunately, that log won't show to us as the message is from
`startCoordinator()` but this is called only when
`hasLeaderPartition(addedPartitions)` true
```
if (hasLeaderPartition(addedPartitions)) {
LOG.info("Committer received leader partition. Starting Coordinator.");
startCoordinator();
}
```
Due to `hasLeaderPartition` silently return false without any logs when
groupDesc.state() is DEAD, the startCoordinator() won't run
```
private boolean hasLeaderPartition(Collection<TopicPartition>
currentAssignedPartitions) {
ConsumerGroupDescription groupDesc;
try (Admin admin = clientFactory.createAdmin()) {
groupDesc =
KafkaUtils.consumerGroupDescription(config.connectGroupId(), admin);
}
if (groupDesc.state() == ConsumerGroupState.STABLE) {
Collection<MemberDescription> members = groupDesc.members();
if (containsFirstPartition(members, currentAssignedPartitions)) {
membersWhenWorkerIsCoordinator = members;
return true;
}
}
return false;
}
``
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
