rdblue commented on code in PR #12658:
URL: https://github.com/apache/iceberg/pull/12658#discussion_r2017538775


##########
format/spec.md:
##########
@@ -648,6 +648,9 @@ Notes:
 5. The `content_offset` and `content_size_in_bytes` fields are used to 
reference a specific blob for direct access to a deletion vector. For deletion 
vectors, these values are required and must exactly match the `offset` and 
`length` stored in the Puffin footer for the deletion vector blob.
 6. The following field ids are reserved on `data_file`: 141.
 
+For `variant` type, the `lower_bounds` and `upper_bounds` store the lower and 
upper bounds for all shredded subcolumns within a file. These bounds are 
represented as a Variant object, where each subcolumn path serves as a key and 
the corresponding bound value as the value. The object is then serialized into 
binary format (see [Variant 
encoding](https://github.com/apache/parquet-format/blob/master/VariantEncoding.md)).

Review Comment:
   This should not state "all shredded subcolumns". First, "all" is not a 
requirement and is actually misleading because the fields are only those for 
which we can guarantee the lower and upper bounds are accurate. I would also 
not use the somewhat confusing term "subcolumn". In the variant spec we refer 
to fields. You may also want to call out a special case where the root is not 
an object. In that case the lower or upper bound is tracked by the field name 
`"$"` indicating the root.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to