danielcweeks commented on code in PR #11577:
URL: https://github.com/apache/iceberg/pull/11577#discussion_r2016986332
##########
azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java:
##########
@@ -25,23 +25,42 @@
import java.util.Collections;
import java.util.Map;
import java.util.Optional;
+import org.apache.iceberg.CatalogProperties;
+import org.apache.iceberg.azure.adlsv2.VendedAdlsCredentialProvider;
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
+import org.apache.iceberg.relocated.com.google.common.base.Strings;
import org.apache.iceberg.relocated.com.google.common.collect.Maps;
+import org.apache.iceberg.rest.RESTUtil;
import org.apache.iceberg.util.PropertyUtil;
+import org.apache.iceberg.util.SerializableMap;
public class AzureProperties implements Serializable {
public static final String ADLS_SAS_TOKEN_PREFIX = "adls.sas-token.";
+ public static final String ADLS_SAS_TOKEN_EXPIRES_AT_MS_PREFIX =
"adls.sas-token-expires-at-ms.";
public static final String ADLS_CONNECTION_STRING_PREFIX =
"adls.connection-string.";
public static final String ADLS_READ_BLOCK_SIZE =
"adls.read.block-size-bytes";
public static final String ADLS_WRITE_BLOCK_SIZE =
"adls.write.block-size-bytes";
public static final String ADLS_SHARED_KEY_ACCOUNT_NAME =
"adls.auth.shared-key.account.name";
public static final String ADLS_SHARED_KEY_ACCOUNT_KEY =
"adls.auth.shared-key.account.key";
+ /**
+ * When set, the {@link VendedAdlsCredentialProvider} will be used to fetch
and refresh vended
+ * credentials from this endpoint.
+ */
+ public static final String ADLS_REFRESH_CREDENTIALS_ENDPOINT =
+ "adls.refresh-credentials-endpoint";
+
+ /** Controls whether vended credentials should be refreshed or not. Defaults
to true. */
+ public static final String ADLS_REFRESH_CREDENTIALS_ENABLED =
"adls.refresh-credentials-enabled";
Review Comment:
Same here: `client.refresh-credentials-enabled`. @nastra do you remember
why we even have this property? Is the presence of the endpoint not signal
enough that we want refresh enabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
