ChaladiMohanVamsi commented on code in PR #11577:
URL: https://github.com/apache/iceberg/pull/11577#discussion_r2016319032
##########
azure/src/main/java/org/apache/iceberg/azure/AzureProperties.java:
##########
@@ -77,6 +104,20 @@ public Optional<Long> adlsWriteBlockSize() {
return Optional.ofNullable(adlsWriteBlockSize);
}
+ public Optional<VendedAdlsCredentialProvider> vendedAdlsCredentialProvider()
{
+ if (adlsRefreshCredentialsEnabled &&
!Strings.isNullOrEmpty(adlsRefreshCredentialsEndpoint)) {
+ Map<String, String> credentialProviderProperties =
Maps.newHashMap(allProperties);
+ credentialProviderProperties.put(
+ VendedAdlsCredentialProvider.URI, adlsRefreshCredentialsEndpoint);
+ Optional.ofNullable(allProperties.get(OAuth2Properties.TOKEN))
Review Comment:
removed redundant operation of setting token.
##########
azure/src/main/java/org/apache/iceberg/azure/adlsv2/ADLSFileIO.java:
##########
@@ -212,4 +219,12 @@ public void deletePrefix(String prefix) {
}
}
}
+
+ @Override
+ public void close() {
+ if (vendedAdlsCredentialProvider != null) {
+ vendedAdlsCredentialProvider.close();
+ }
Review Comment:
applied
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
