deniskuzZ commented on code in PR #12629:
URL: https://github.com/apache/iceberg/pull/12629#discussion_r2016823821


##########
core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java:
##########
@@ -45,22 +49,53 @@ private PartitionStatsUtil() {}
    * @param table the table for which partition stats to be computed.
    * @param snapshot the snapshot for which partition stats is computed.
    * @return the collection of {@link PartitionStats}
+   * @deprecated since 1.9.0, will be removed in 1.10.0; use {@link 
#computeStats(Table, Snapshot,
+   *     Snapshot)} instead.
    */
+  @Deprecated

Review Comment:
   Please extend `PartitionStatsUtil` API just with an incremental recompute:
   ```` 
   // full recompute
    public static Collection<PartitionStats> computeStats(Table table, Snapshot 
snapshot) 
   
   and
   
    // incremental recompute
    public static PartitionMap<PartitionStats> computeStatsIncremental(Table 
table, Snapshot fromSnapshot, Snapshot currentSnapshot) 
   ````



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to