deniskuzZ commented on code in PR #12629:
URL: https://github.com/apache/iceberg/pull/12629#discussion_r2016815949
##########
core/src/main/java/org/apache/iceberg/PartitionStatsUtil.java:
##########
@@ -45,22 +49,53 @@ private PartitionStatsUtil() {}
* @param table the table for which partition stats to be computed.
* @param snapshot the snapshot for which partition stats is computed.
* @return the collection of {@link PartitionStats}
+ * @deprecated since 1.9.0, will be removed in 1.10.0; use {@link
#computeStats(Table, Snapshot,
+ * Snapshot)} instead.
*/
+ @Deprecated
Review Comment:
filling what map again?
````
Collection<PartitionStats> partitionStats;
if (recompute) {
partitionStats = PartitionStatsUtil.computeStats(table, snapshot);
} else {
partitionStats = incrementalComputeAndMerge(table, snapshot,
partitionType)values();
}
if (partitionStats.isEmpty()) {
return null;
}
List<PartitionStats> sortedStats =
PartitionStatsUtil.sortStats(partitionStats,
...
private static PartitionMap<PartitionStats> incrementalComputeAndMerge(
Table table, Snapshot snapshot, StructType partitionType)
....
return statsMap.values()
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
