wgtmac commented on code in PR #12644:
URL: https://github.com/apache/iceberg/pull/12644#discussion_r2015906621
##########
format/spec.md:
##########
@@ -1453,13 +1457,15 @@ Each sort field in the fields list is stored as an
object with the following pro
| V1 | V2 | V3 | Field | JSON representation |
Example |
|----------|----------|----------|------------------|---------------------|-------------|
-| required | required | required | **`transform`** | `JSON string` |
`bucket[4]` |
-| required | required | omitted | **`source-id`** | `JSON int` | 1
|
+| required | required | required¹ | **`transform`** | `JSON string` |
`bucket[4]` |
Review Comment:
I guess the note is in the wrong place?
##########
format/spec.md:
##########
@@ -1414,12 +1414,16 @@ Each partition field in `fields` is stored as a JSON
object with the following p
| V1 | V2 | V3 | Field | JSON representation |
Example |
|----------|----------|----------|------------------|---------------------|--------------|
-| required | required | omitted | **`source-id`** | `JSON int` | 1
|
Review Comment:
If both `source-ids` and `source-id` are written for single-arg transform, a
v3-supported reader can take a shortcut on `source-ids` and only fall back to
`source-id` when `source-ids` is missing. Isn't this a desirable feature?
Though someone may argue that we have to check the consistency between them
like the above discussion.
##########
format/spec.md:
##########
@@ -1605,13 +1611,8 @@ All readers are required to read tables with unknown
partition transforms, ignor
Writing v3 metadata:
* Partition Field and Sort Field JSON:
- * `source-ids` was added and is required
- * `source-id` is no longer required and should be omitted; always use
`source-ids` instead
-
-Reading v1 or v2 metadata for v3:
-
-* Partition Field and Sort Field JSON:
- * `source-ids` should default to a single-value list of the value of
`source-id`
+ * `source-ids` was added and is required in case of multi-argument
transforms.
Review Comment:
```suggestion
* `source-ids` was added and is required in the case of multi-argument
transforms.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
