Fokko opened a new pull request, #12644:
URL: https://github.com/apache/iceberg/pull/12644

   Changes around the multi-argument transforms, mainly two things:
   
   - **Up for debate**. The spec does not point out an actual implementations 
of transforms that accept multiple arguments. From the existing transforms, the 
only contender is the bucket transform. Should we include this in the V3 spec? 
It will only allow to prune metadata if you do an equality expression on all 
the fields that are part of the transform.
   - Along the way, we've [removed something that we did not 
intend](https://github.com/apache/iceberg/blame/10ec85ffcab6ac12ecac7fc6df9c3e4139f857b7/format/spec.md#L1139-L1140).
 First we allowed to write source-id and source-ids based on the number of 
arguments. This has been changed to only allow source-ids for V3 in a PR that 
introduces backward compatibility. I think this makes the JSON 
parsers/producers more complex than needed (specifically PyIceberg). Also, in 
Java we would need to plumb down the table  version to the 
[PartitionSpecParser.java](https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/PartitionSpecParser.java#L101).
 I think it would be great to simplify this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to